Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4532#discussion_r25406876
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala ---
    @@ -248,7 +249,7 @@ private[hive] object HadoopTableReader extends 
HiveInspectors {
        * instantiate a HadoopRDD.
        */
       def initializeLocalJobConfFunc(path: String, tableDesc: 
TableDesc)(jobConf: JobConf) {
    -    FileInputFormat.setInputPaths(jobConf, path)
    +    jobConf.set("mapred.input.dir", 
StringUtils.escapeString(path.toString()))
    --- End diff --
    
    o, I see. `getPathStrings` does not really care if a comma is escaped or 
not... Can we use `public static void setInputPaths(Job job,  Path... 
inputPaths)`? I think it is better to avoid using `set` directly with a string 
key (using a method seems more robust).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to