HeartSaVioR commented on a change in pull request #27664: [SPARK-30915][SS] 
FileStreamSink: Avoid reading the metadata log file when finding the latest 
batch ID
URL: https://github.com/apache/spark/pull/27664#discussion_r382452944
 
 

 ##########
 File path: 
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/FileStreamSinkLogSuite.scala
 ##########
 @@ -240,6 +247,40 @@ class FileStreamSinkLogSuite extends SparkFunSuite with 
SharedSparkSession {
     ))
   }
 
+  test("getLatestBatchId") {
 
 Review comment:
   I don't add E2E test to simplify the test code, but if we prefer E2E than 
I'll try to add a new test to FileStreamSinkSuite.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to