maropu commented on a change in pull request #27597: [SPARK-30844][SQL]Static
partition should also follow StoreAssignmentPolicy when insert into table
URL: https://github.com/apache/spark/pull/27597#discussion_r382599108
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -104,7 +105,17 @@ case class DataSourceAnalysis(conf: SQLConf) extends
Rule[LogicalPlan] with Cast
None
} else if (potentialSpecs.size == 1) {
val partValue = potentialSpecs.head._2
- Some(Alias(cast(Literal(partValue), field.dataType), field.name)())
+ conf.storeAssignmentPolicy match {
+ // SPARK-30844: try our best to follow StoreAssignmentPolicy for
static partition
+ // values but not completely follow because we can't do static type
checking due to
+ // the reason that the parser has erased the type info of static
partition values
+ // and converted them to string.
Review comment:
Oh, I missed that...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
