Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4055#discussion_r25416698
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -483,8 +483,9 @@ private[spark] class TaskSetManager(
// a good proxy to task serialization time.
// val timeTaken = clock.getTime() - startTime
val taskName = s"task ${info.id} in stage ${taskSet.id}"
- logInfo("Starting %s (TID %d, %s, %s, %d bytes)".format(
- taskName, taskId, host, taskLocality, serializedTask.limit))
+ logInfo("Starting %s (TID %d, %s, %d, %s, %d bytes)".format(
--- End diff --
The `s"..."` didn't exist before Spark 2.10, so I think that's why the old
style is still used in the code. There's no great need to change all that. I
think the interpolated style is clearer, and I tend to think that we should
match surrounding code style in issues like this. Since interpolation is used
in the line above, it seems right to use it here. I agree it's a tiny issue
either way.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
