JkSelf commented on a change in pull request #27669: [SPARK-30918][SQL] improve 
the splitting of skewed partitions
URL: https://github.com/apache/spark/pull/27669#discussion_r382878571
 
 

 ##########
 File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
 ##########
 @@ -445,6 +445,7 @@ object SQLConf {
         " this factor multiple the median partition size and also larger than 
" +
         s" ${ADAPTIVE_EXECUTION_SKEWED_PARTITION_SIZE_THRESHOLD.key}")
       .intConf
+      .checkValue(_ > 0, "The skew factor must be positive.")
 
 Review comment:
   When the `nonSkewSizes ` is very small. The `targetSize ` will be small 
without this config. Then it will split more small task when handling skewed 
partition? So we may need this config.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to