Github user suyanNone commented on a diff in the pull request:
https://github.com/apache/spark/pull/3629#discussion_r25421661
--- Diff: core/src/main/scala/org/apache/spark/storage/MemoryStore.scala ---
@@ -328,6 +330,7 @@ private[spark] class MemoryStore(blockManager:
BlockManager, maxMemory: Long)
val droppedBlocks = new ArrayBuffer[(BlockId, BlockStatus)]
accountingLock.synchronized {
+ releasePendingUnrollMemoryForThisThread()
--- End diff --
@andrewor14
If put it at the end of `accountingLock.synchronized`, as I described
above,
```
accountingLock.synchronized {
1. ensureFreeSpace() //here will call the currentUnrollMemory, it will
re-count the pendingUnrollmemmory to get freeMemory, then to judge whether free
space or not.
2. entries.put(blockId, entry)
}
```
If still need to put it at the end of `accountingLock.synchronized`, for
get free space in ensureFreeSpace.
may change the current code `val actualFreeMemory = freeMemory -
currentUnrollMemory` to `val actualFreeMemory = freeMemory -
currentUnrollMemory + unrollPendingMmeory(threadId)`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
