Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/4588#discussion_r25422350
--- Diff: core/src/main/scala/org/apache/spark/rpc/ActionScheduler.scala ---
@@ -0,0 +1,207 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.rpc
+
+import java.util.concurrent.atomic.AtomicReference
+import java.util.concurrent.{SynchronousQueue, TimeUnit,
ThreadPoolExecutor}
+
+import scala.concurrent.duration.FiniteDuration
+import scala.concurrent.ExecutionContext
+import scala.util.control.NonFatal
+
+import io.netty.util.{Timeout, TimerTask, HashedWheelTimer}
+
+import org.apache.spark.util.Utils
+import org.apache.spark.{Logging, SparkConf}
+
+/**
+ * It's very common that executing some actions in other threads to avoid
blocking the event loop
+ * in a RpcEndpoint. [[ActionScheduler]] is designed for such use cases.
+ */
+private[spark] trait ActionScheduler {
+
+ /**
+ * Run the action in the IO thread pool. The thread name will be `name`
when running this action.
+ */
+ def executeIOAction(name: String)(action: => Unit): Unit
+
+ /**
+ * Run the action in the CPU thread pool. The thread name will be `name`
when running this action.
+ */
+ def executeCPUAction(name: String)(action: => Unit): Unit
+
+ /**
+ * Run the action after `delay`. The thread name will be `name` when
running this action.
+ */
+ def schedule(name: String, delay: FiniteDuration)(action: => Unit):
Cancellable
+
+
+ /**
+ * Run the action every `interval`. The thread name will be `name` when
running this action.
+ */
+ def schedulePeriodically(name: String, interval: FiniteDuration)(action:
=> Unit): Cancellable = {
+ schedulePeriodically(name, interval, interval)(action)
+ }
+
+ /**
+ * Run the action every `interval`. The thread name will be `name` when
running this action.
+ */
+ def schedulePeriodically(
+ name: String, delay: FiniteDuration, interval:
FiniteDuration)(action: => Unit): Cancellable
+}
+
+private[spark] trait Cancellable {
+ // Should be reentrant
+ def cancel(): Unit
+}
+
+private[rpc] object NopCancellable extends Cancellable {
+ override def cancel(): Unit = {}
+}
+
+private[rpc] class SettableCancellable extends Cancellable {
--- End diff --
I removed NopCancellable and add a const in object SettableCancellable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
