imback82 commented on a change in pull request #27391: [SPARK-30612][SQL]
Resolve qualified column name with v2 tables
URL: https://github.com/apache/spark/pull/27391#discussion_r382964704
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala
##########
@@ -678,6 +678,44 @@ class DataSourceV2SQLSuite
}
}
+ test("qualified column names for v2 tables") {
+ val t = "testcat.ns1.ns2.tbl"
+ withTable(t) {
+ sql(s"CREATE TABLE $t (id bigint, point struct<x: bigint, y: bigint>)
USING foo")
+ sql(s"INSERT INTO $t VALUES (1, (10, 20))")
+
+ checkAnswer(
+ sql(s"SELECT testcat.ns1.ns2.tbl.id, testcat.ns1.ns2.tbl.point.x FROM
$t"),
+ Row(1, 10))
+ checkAnswer(sql(s"SELECT ns1.ns2.tbl.id, ns1.ns2.tbl.point.x FROM $t"),
Row(1, 10))
+ checkAnswer(sql(s"SELECT ns2.tbl.id, ns2.tbl.point.x FROM $t"), Row(1,
10))
+ checkAnswer(sql(s"SELECT tbl.id, tbl.point.x FROM $t"), Row(1, 10))
+
+ val ex = intercept[AnalysisException] {
+ sql(s"SELECT ns1.ns2.ns3.tbl.id from $t")
+ }
+ assert(ex.getMessage.contains("cannot resolve '`ns1.ns2.ns3.tbl.id`"))
+ }
+ }
+
+ test("qualified column names for v1 tables") {
+ // unset this config to use the default v2 session catalog.
+ spark.conf.unset(V2_SESSION_CATALOG_IMPLEMENTATION.key)
+
+ withTable("t") {
+ sql("CREATE TABLE t USING json AS SELECT 1 AS i")
+ checkAnswer(sql("select default.t.i from spark_catalog.t"), Row(1))
+ checkAnswer(sql("select t.i from spark_catalog.default.t"), Row(1))
+ checkAnswer(sql("select default.t.i from spark_catalog.default.t"),
Row(1))
+
+ // catalog name cannot be used for v1 tables.
Review comment:
Using catalog name for v1 tables requires changes on the existing resolution
rule (`matchWithTwoOrLessQualifierParts`) unless we fall back to new rule. This
will be a 3.1 feature and I can update `matchWithTwoOrLessQualifierParts` now?
I wanted to make sure before I get started. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
