HyukjinKwon commented on a change in pull request #27663: [SPARK-30895]:The 
behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#discussion_r383129253
 
 

 ##########
 File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/csvExpressions.scala
 ##########
 @@ -136,6 +139,21 @@ case class CsvToStructs(
   override def prettyName: String = "from_csv"
 }
 
+object CsvToStructs{
+  def apply(
 
 Review comment:
   @lipzhu, can you also check the style guide at 
https://github.com/databricks/scala-style-guide?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to