cloud-fan commented on a change in pull request #27672: [SPARK-30919][SQL] Make
interval multiply and divide's overflow behavior consistent with other
operations
URL: https://github.com/apache/spark/pull/27672#discussion_r383183969
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/intervalExpressions.scala
##########
@@ -137,10 +139,22 @@ abstract class IntervalNumOperation(
}
case class MultiplyInterval(interval: Expression, num: Expression)
- extends IntervalNumOperation(interval, num, multiplyExact, "multiplyExact")
+ extends IntervalNumOperation(interval, num) {
+
+ override protected val operation: (CalendarInterval, Double) =>
CalendarInterval =
+ (interval, num) => if (checkOverflow) multiplyExact(interval, num) else
multiply(interval, num)
Review comment:
This still checks overflow per-row...
```
if (checkOverflow) multiplyExact else multiply
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
