Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4214#discussion_r25465389
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
    @@ -44,8 +48,15 @@ private[history] class FsHistoryProvider(conf: 
SparkConf) extends ApplicationHis
       private val NOT_STARTED = "<Not Started>"
     
       // Interval between each check for event log updates
    -  private val UPDATE_INTERVAL_MS = 
conf.getInt("spark.history.fs.updateInterval",
    -    conf.getInt("spark.history.updateInterval", 10)) * 1000
    +  private val UPDATE_INTERVAL_MS = 
conf.getOption("spark.history.fs.update.interval.seconds")
    +    
.orElse(conf.getOption(SparkConf.translateConfKey("spark.history.fs.updateInterval",
 true)))
    +    
.orElse(conf.getOption(SparkConf.translateConfKey("spark.history.updateInterval",
 true)))
    --- End diff --
    
    We shouldn't call `translateConfKey` here, but I realize we need to do so 
if we want to warn the user. I will submit a separate patch to fix this 
behavior. In general I think the `translateConfKey` method should be private to 
`SparkConf`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to