tgravescs commented on a change in pull request #27686: [SPARK-30942] Fix the
warning for requiring cores to be limiting resources
URL: https://github.com/apache/spark/pull/27686#discussion_r383933236
##########
File path: core/src/main/scala/org/apache/spark/SparkContext.scala
##########
@@ -2798,7 +2798,7 @@ object SparkContext extends Logging {
defaultProf.maxTasksPerExecutor(sc.conf) < cpuSlots) {
throw new IllegalArgumentException("The number of slots on an executor
has to be " +
"limited by the number of cores, otherwise you waste resources and "
+
- "dynamic allocation doesn't work properly. Your configuration has " +
+ "some scheduling doesn't work properly. Your configuration has " +
Review comment:
I don't see the point of giving the examples, this is a temporary error
that will go away when when the rest of the feature is put in. The end user
just needs to know cores has to be limiting factor. All they need to know is
spark won't work right if you don't.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
