cloud-fan commented on a change in pull request #27532: [SPARK-30782][SQL]
Column resolution doesn't respect current catalog/namespace for v2 tables.
URL: https://github.com/apache/spark/pull/27532#discussion_r384279065
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala
##########
@@ -700,19 +709,29 @@ class DataSourceV2SQLSuite
}
test("qualified column names for v1 tables") {
- // unset this config to use the default v2 session catalog.
- spark.conf.unset(V2_SESSION_CATALOG_IMPLEMENTATION.key)
-
- withTable("t") {
- sql("CREATE TABLE t USING json AS SELECT 1 AS i")
- checkAnswer(sql("select t.i from spark_catalog.default.t"), Row(1))
- checkAnswer(sql("select default.t.i from spark_catalog.default.t"),
Row(1))
+ Seq(true, false).foreach { useV1Table =>
+ val format = if (useV1Table) "json" else v2Format
+ if (useV1Table) {
+ spark.conf.unset(V2_SESSION_CATALOG_IMPLEMENTATION.key)
+ } else {
+ spark.conf.set(
+ V2_SESSION_CATALOG_IMPLEMENTATION.key,
classOf[InMemoryTableSessionCatalog].getName)
+ }
- // catalog name cannot be used for v1 tables.
- val ex = intercept[AnalysisException] {
- sql(s"select spark_catalog.default.t.i from spark_catalog.default.t")
+ withTable("t") {
+ sql(s"CREATE TABLE t USING $format AS SELECT 1 AS i")
+ checkAnswer(sql("select i from t"), Row(1))
+ checkAnswer(sql("select t.i from t"), Row(1))
+ checkAnswer(sql("select default.t.i from t"), Row(1))
+ checkAnswer(sql("select t.i from spark_catalog.default.t"), Row(1))
+ checkAnswer(sql("select default.t.i from spark_catalog.default.t"),
Row(1))
+
+ // catalog name cannot be used for v1 tables.
Review comment:
`v1 tables` -> `tables in the session catalog`, as we are testing both v1
and v2 tables here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
