zhengruifeng commented on a change in pull request #22921:
[SPARK-25908][CORE][SQL] Remove old deprecated items in Spark 3
URL: https://github.com/apache/spark/pull/22921#discussion_r384292322
##########
File path: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala
##########
@@ -281,9 +265,6 @@ class GeneralMLWriter(stage: PipelineStage) extends
MLWriter with Logging {
// override for Java compatibility
override def session(sparkSession: SparkSession): this.type =
super.session(sparkSession)
-
- // override for Java compatibility
- override def context(sqlContext: SQLContext): this.type =
super.session(sqlContext.sparkSession)
Review comment:
@srowen This public method seems had not been deprecated before removal, and
is avaiable in 2.4.5.
```
scala> import org.apache.spark.ml.util.GeneralMLWriter
import org.apache.spark.ml.util.GeneralMLWriter
scala> new GeneralMLWriter(null).context(spark.sqlContext)
res0: org.apache.spark.ml.util.GeneralMLWriter =
org.apache.spark.ml.util.GeneralMLWriter@26b150cd
```
There is no deprecation warning above. Does it matter?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
