Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/4688#discussion_r25475924
--- Diff:
yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnSparkHadoopUtil.scala ---
@@ -82,6 +93,102 @@ class YarnSparkHadoopUtil extends SparkHadoopUtil {
if (credentials != null) credentials.getSecretKey(new Text(key)) else
null
}
+ override def setPrincipalAndKeytabForLogin(principal: String, keytab:
String): Unit = {
+ loginPrincipal = Option(principal)
+ keytabFile = Option(keytab)
+ }
+
+ private[spark] override def scheduleLoginFromKeytab(
+ callback: (SerializableBuffer) => Unit): Unit = {
+
+ loginPrincipal match {
--- End diff --
Another case where I don't think `match` makes things any clearer. I'd
either just have naked, nullable references, or just check `if
(loginPrincipal.isDefined)`, or use `loginPrincipal.foreach`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
