maropu commented on a change in pull request #27702: [SPARK-30955][SQL] Exclude
Generate output when aliasing in nested column pruning
URL: https://github.com/apache/spark/pull/27702#discussion_r384315612
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala
##########
@@ -107,16 +107,17 @@ object NestedColumnAliasing {
* 1. ExtractValue -> Alias: A new alias is created for each nested field.
* 2. ExprId -> Seq[Alias]: A reference attribute has multiple aliases
pointing it.
*/
- def getAliasSubMap(exprList: Seq[Expression])
+ def getAliasSubMap(exprList: Seq[Expression], exclusiveAttrs: Seq[Attribute]
= Seq.empty)
Review comment:
Ur, I see. This is a nit comment though, I feel sharing `getAliasSubMap` in
both cases (`project w/generate case` and `simple project case`) makes the
function arguments a bit complicated. So, its better to leave some comments
about the argument `exclusiveAttrs` in the line 105.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
