viirya commented on a change in pull request #27656: [SPARK-30898][SQL] The
nullability of MakeDecimal should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27656#discussion_r384329641
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/decimalExpressions.scala
##########
@@ -45,9 +45,15 @@ case class UnscaledValue(child: Expression) extends
UnaryExpression {
* Note: this expression is internal and created only by the optimizer,
* we don't need to do type check for it.
*/
-case class MakeDecimal(child: Expression, precision: Int, scale: Int) extends
UnaryExpression {
+case class MakeDecimal(
+ child: Expression,
+ precision: Int,
+ scale: Int,
+ nullOnOverflow: Boolean) extends UnaryExpression {
- private val nullOnOverflow = !SQLConf.get.ansiEnabled
Review comment:
We should have tests to for such behaviors. Otherwise, we could possibly
change it unintentionally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
