hvanhovell commented on a change in pull request #27703:
[SPARK-30798][SQL][TESTS][FOLLOW-UP] Set the configuration against the current
session explicitly in HiveShowCreateTableSuite
URL: https://github.com/apache/spark/pull/27703#discussion_r384360661
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveShowCreateTableSuite.scala
##########
@@ -30,12 +30,13 @@ class HiveShowCreateTableSuite extends
ShowCreateTableSuite with TestHiveSinglet
protected override def beforeAll(): Unit = {
super.beforeAll()
origCreateHiveTableConfig =
- SQLConf.get.getConf(SQLConf.LEGACY_CREATE_HIVE_TABLE_BY_DEFAULT_ENABLED)
- SQLConf.get.setConf(SQLConf.LEGACY_CREATE_HIVE_TABLE_BY_DEFAULT_ENABLED,
true)
+ spark.conf.get(SQLConf.LEGACY_CREATE_HIVE_TABLE_BY_DEFAULT_ENABLED)
Review comment:
Slightly tangential remark, in this case we could also clone the session.
That way we don't have to undo setting this flag in `afterAll()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
