Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/4797#discussion_r25478499
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -49,8 +49,8 @@ private[history] class FsHistoryProvider(conf: SparkConf)
extends ApplicationHis
// Interval between each check for event log updates
private val UPDATE_INTERVAL_MS =
conf.getOption("spark.history.fs.update.interval.seconds")
-
.orElse(conf.getOption(SparkConf.translateConfKey("spark.history.fs.updateInterval",
true)))
-
.orElse(conf.getOption(SparkConf.translateConfKey("spark.history.updateInterval",
true)))
+ .orElse(conf.getOption("spark.history.fs.updateInterval"))
+ .orElse(conf.getOption("spark.history.updateInterval"))
--- End diff --
BTW, it's not necessary to call `get` with the old names here. The code in
SparkConf will print the deprecation warning when the old option names are set,
and internally `translateKey` will always ensure the new option name is used.
So the two `orElse` here are basically reduntant.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
