tgravescs commented on a change in pull request #27693: [SPARK-30947][CORE] Log
better message when accelerate resource is empty
URL: https://github.com/apache/spark/pull/27693#discussion_r384540538
##########
File path: core/src/main/scala/org/apache/spark/resource/ResourceUtils.scala
##########
@@ -362,8 +362,13 @@ private[spark] object ResourceUtils extends Logging {
def logResourceInfo(componentName: String, resources: Map[String,
ResourceInformation])
: Unit = {
+ val resourceInfo = if (resources.isEmpty) {
+ s"No extra accelerate resources configured for $componentName."
+ } else {
+ s"Accelerate Resources for $componentName:\n${resources.mkString("\n")}"
Review comment:
nit - remove Accelerate from here and line 366. If you want something more
specific I would put Custom resources and No custom resources configured just
to stay consistent with documentation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
