dongjoon-hyun commented on a change in pull request #27702: [SPARK-30955][SQL] 
Exclude Generate output when aliasing in nested column pruning
URL: https://github.com/apache/spark/pull/27702#discussion_r385010541
 
 

 ##########
 File path: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/SchemaPruningSuite.scala
 ##########
 @@ -301,6 +301,24 @@ abstract class SchemaPruningSuite
     checkAnswer(query, Row("Y.", 1) :: Row("X.", 1) :: Row(null, 2) :: 
Row(null, 2) :: Nil)
   }
 
+  testSchemaPruning("select explode of nested field of array of struct from 
Generate output") {
 
 Review comment:
   Sorry, but I agree with @HyukjinKwon 's comment. This will be executed 16 
times in `testSchemaPruning` x (ORCv1/ORCv2/Parquetv1/Parquetv2) without any 
benefit. If you need to add a E2E test, the original place is better than this.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to