gaborgsomogyi commented on a change in pull request #27637: [SPARK-30874][SQL] 
Support Postgres Kerberos login in JDBC connector
URL: https://github.com/apache/spark/pull/27637#discussion_r385102968
 
 

 ##########
 File path: docs/sql-data-sources-jdbc.md
 ##########
 @@ -197,6 +197,20 @@ the following case-insensitive options:
      The option to enable or disable predicate push-down into the JDBC data 
source. The default value is true, in which case Spark will push down filters 
to the JDBC data source as much as possible. Otherwise, if set to false, no 
filter will be pushed down to the JDBC data source and thus all filters will be 
handled by Spark. Predicate push-down is usually turned off when the predicate 
filtering is performed faster by Spark than by the JDBC data source.
     </td>
   </tr>
+
+  <tr>
+    <td><code>keytab</code></td>
 
 Review comment:
   > e.g. if the postgres jdbc url syntax allows for these options to be 
defined there, you could check whether there's a placeholder for the principal 
/ keytab and replace with some globally-set Spark config.
   
   I've considered global config but since Spark can use multiple databases at 
the same time like postgres on source side and oracle on sink side I thought it 
would make the implementation rigid.
   
   The other option which is the jdbc url also considered but that way for each 
database type an url parser must be implemented which I thought is an overkill 
(for instance postgres uses `&` as separator and MSSQL uses `;`).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to