cloud-fan commented on a change in pull request #27552: [SPARK-30808][SQL]
Enable Java 8 time API in Thrift server
URL: https://github.com/apache/spark/pull/27552#discussion_r385115198
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
##########
@@ -512,7 +511,7 @@ class SQLQueryTestSuite extends QueryTest with
SharedSparkSession {
val schema = df.schema.catalogString
// Get answer, but also get rid of the #1234 expression ids that show up
in explain plans
val answer = SQLExecution.withNewExecutionId(df.queryExecution, Some(sql))
{
-
hiveResultString(df.queryExecution.executedPlan).map(replaceNotIncludedMsg)
+ hiveResultString(df).map(replaceNotIncludedMsg)
Review comment:
in `ThriftServerQueryTestSuite`, we get the result by JDBC, so there is no
DataFrame created.
We should follow pgsql and return java 8 datetime when the config is
enabled. https://jdbc.postgresql.org/documentation/head/8-date-time.html
cc @wangyum @yaooqinn
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
