HyukjinKwon commented on a change in pull request #27534: [SPARK-30879][DOCS] Refine workflow for building docs URL: https://github.com/apache/spark/pull/27534#discussion_r385479036
########## File path: docs/README.md ########## @@ -58,7 +84,7 @@ Note: Other versions of roxygen2 might work in SparkR documentation generation b To generate API docs for any language, you'll need to install these libraries: ```sh -$ sudo pip install sphinx mkdocs numpy +pip install sphinx==2.3.1 mkdocs==1.0.4 numpy==1.18.1 Review comment: Hm, there's tradeoff to pin the version (promote to test and fix it compatible first vs prevent to break at the latest versions). I think we haven't faced any notable problem so far to maintain those implicit compatibility across versions. What about we pin the version when actually we see some overhead to maintain this? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
