yaooqinn commented on a change in pull request #27552: [SPARK-30808][SQL]
Enable Java 8 time API in Thrift server
URL: https://github.com/apache/spark/pull/27552#discussion_r385492731
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
##########
@@ -512,7 +511,7 @@ class SQLQueryTestSuite extends QueryTest with
SharedSparkSession {
val schema = df.schema.catalogString
// Get answer, but also get rid of the #1234 expression ids that show up
in explain plans
val answer = SQLExecution.withNewExecutionId(df.queryExecution, Some(sql))
{
-
hiveResultString(df.queryExecution.executedPlan).map(replaceNotIncludedMsg)
+ hiveResultString(df).map(replaceNotIncludedMsg)
Review comment:
We do not have our own JDBC implementation yet, and the hive JDBC haven't
supported this too
https://github.com/apache/hive/blob/ebd41526b9433a196ae0f934bc466cb5c155a202/jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java#L402-L411
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
