huaxingao commented on issue #27729: [MINOR][SQL] Remove unnecessary MiMa excludes URL: https://github.com/apache/spark/pull/27729#issuecomment-592336091 @HyukjinKwon You are too fast :) I am actually thinking of making one more change for this PR. I will change ``` // Data Source V2 API changes (problem: Problem) => problem match { case MissingClassProblem(cls) => !cls.fullName.startsWith("org.apache.spark.sql.sources.v2") case MissingTypesProblem(newCls, _) => !newCls.fullName.startsWith("org.apache.spark.sql.sources.v2") case InheritedNewAbstractMethodProblem(cls, _) => !cls.fullName.startsWith("org.apache.spark.sql.sources.v2") case DirectMissingMethodProblem(meth) => !meth.owner.fullName.startsWith("org.apache.spark.sql.sources.v2") case ReversedMissingMethodProblem(meth) => !meth.owner.fullName.startsWith("org.apache.spark.sql.sources.v2") case _ => true } ``` to ``` // Data Source V2 API changes (problem: Problem) => problem match { case MissingClassProblem(cls) => !cls.fullName.startsWith("org.apache.spark.sql.sources.v2") case _ => true ``` because of https://github.com/apache/spark/pull/25700 I guess I will have a follow-up?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
