cloud-fan commented on a change in pull request #27650: [SPARK-30902][SQL]
Default table provider should be decided by catalog implementations
URL: https://github.com/apache/spark/pull/27650#discussion_r385587804
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveCatalogs.scala
##########
@@ -174,7 +174,7 @@ class ResolveCatalogs(val catalogManager: CatalogManager)
c.tableSchema,
// convert the bucket spec and add it as a transform
c.partitioning ++ c.bucketSpec.map(_.asTransform),
- convertTableProperties(c.properties, c.options, c.location, c.comment,
c.provider),
+ convertTableProperties(c.properties, c.options, c.location, c.comment,
Some(c.provider)),
Review comment:
https://github.com/cloud-fan/spark/blob/6685dc5dbbbea0f4cd069f1a5e92ccb70033f493/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala#L2826
This is how the parser gets the provider. I don't think it can be null.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
