dbtsai commented on a change in pull request #27728: [SPARK-17636][SQL] Nested
Column Predicate Pushdown for Parquet
URL: https://github.com/apache/spark/pull/27728#discussion_r385982443
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala
##########
@@ -466,13 +485,8 @@ class ParquetFilters(
case _ => false
}
- // Parquet does not allow dots in the column name because dots are used as a
column path
- // delimiter. Since Parquet 1.8.2 (PARQUET-389), Parquet accepts the filter
predicates
- // with missing columns. The incorrect results could be got from Parquet
when we push down
- // filters for the column having dots in the names. Thus, we do not push
down such filters.
- // See SPARK-20364.
private def canMakeFilterOn(name: String, value: Any): Boolean = {
- nameToParquetField.contains(name) && !name.contains(".") &&
valueCanMakeFilterOn(name, value)
+ nameToParquetField.contains(name) && valueCanMakeFilterOn(name, value)
Review comment:
No. we don't have to. Should work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
