maryannxue commented on a change in pull request #27742: [SPARK-30991] Refactor
AQE readers and RDDs
URL: https://github.com/apache/spark/pull/27742#discussion_r385997035
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/OptimizeSkewedJoin.scala
##########
@@ -277,44 +273,29 @@ case class OptimizeSkewedJoin(conf: SQLConf) extends
Rule[SparkPlan] {
assert(nonSkewPartitionIndices.nonEmpty)
val shouldCoalesce =
conf.getConf(SQLConf.REDUCE_POST_SHUFFLE_PARTITIONS_ENABLED)
if (!shouldCoalesce || nonSkewPartitionIndices.length == 1) {
- Seq(SinglePartitionSpec(nonSkewPartitionIndices.head))
Review comment:
This was a bug too? when `shouldCoalesce == false &&
nonSkewPartitionIndices.length > 1`, it should be
`nonSkewPartitionIndices.map(SinglePartitionSpec)`, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
