nchammas commented on a change in pull request #27534: [SPARK-30879][DOCS] 
Refine workflow for building docs
URL: https://github.com/apache/spark/pull/27534#discussion_r386124063
 
 

 ##########
 File path: docs/README.md
 ##########
 @@ -31,15 +31,41 @@ whichever version of Spark you currently have checked out 
of revision control.
 The Spark documentation build uses a number of tools to build HTML docs and 
API docs in Scala, Java,
 Python, R and SQL.
 
-You need to have 
[Ruby](https://www.ruby-lang.org/en/documentation/installation/) and
-[Python](https://docs.python.org/2/using/unix.html#getting-and-installing-the-latest-version-of-python)
-installed. Also install the following libraries:
+You need to have Ruby 2 and Python 3 installed. A handy way to install and 
manage various versions of Ruby and Python is with [`rbenv`] and [`pyenv`].
 
 Review comment:
   We can just tell people to install Ruby 2 and Python 3, but without 
specifying specific versions of them we risk having contributors and committers 
waste time dealing with library versions that are incompatible with the version 
of the language/runtime they have installed, or that somehow don't work with 
our configuration.
   
   It's a small risk, but I figured if we're going to use rbenv and pyenv in 
building the Docker image, it would make sense to recommend them for the 
interactive/local workflow as well. The experience is consistent, which is 
what's nice about using these tools, and they are "lower level" than things 
like Conda in that they are relatively simple shell scripts that only manage 
installations.
   
   Are you OK with using rbenv and pyenv in the Docker image?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to