HyukjinKwon commented on a change in pull request #27754: [SPARK-31003][TESTS]
Fix incorrect uses of assume() in tests
URL: https://github.com/apache/spark/pull/27754#discussion_r386189796
##########
File path: core/src/test/scala/org/apache/spark/storage/LocalDirsSuite.scala
##########
@@ -39,7 +39,7 @@ class LocalDirsSuite extends SparkFunSuite with
BeforeAndAfter {
private def assumeNonExistentAndNotCreatable(f: File): Unit = {
try {
- assume(!f.exists() && !f.mkdirs())
+ assert(!f.exists() && !f.mkdirs())
Review comment:
@JoshRosen, this assume was intentional (see
https://github.com/apache/spark/pull/17987/files#r116532209) because
`/NENEXISTENT_PATH` can be a valid path. We should ideally fix the tests to
make it invalid paths in all OSs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
