cloud-fan commented on a change in pull request #27750: [SPARK-30998][SQL]
ClassCastException when a generator having nested inner generators
URL: https://github.com/apache/spark/pull/27750#discussion_r386211633
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/TestRelations.scala
##########
@@ -62,6 +62,9 @@ object TestRelations {
val listRelation = LocalRelation(
AttributeReference("list", ArrayType(IntegerType))())
+ val nestedListRelation = LocalRelation(
Review comment:
will this relation be used in more tests? if not let's inline it in your
test case.
Note that, the more common test relations we have, the harder to review test
cases, as we need to search the definition of the used test relations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
