Ngone51 commented on a change in pull request #27752: [SPARK-30999][SQL] Don't
cancel a QueryStageExec which is already finished
URL: https://github.com/apache/spark/pull/27752#discussion_r386220603
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala
##########
@@ -158,25 +158,34 @@ case class AdaptiveSparkPlanExec(
var result = createQueryStages(currentPhysicalPlan)
val events = new LinkedBlockingQueue[StageMaterializationEvent]()
val errors = new mutable.ArrayBuffer[SparkException]()
+ val runningStages = util.Collections.synchronizedSet(new
util.HashSet[QueryStageExec]())
Review comment:
Ok, but we still need to exclude finished but failed
stage(`Future.isFailure`) whose `resultOption` is empty in this way?
Maybe, we can assign `resultOption` to the exception for failed stages.
Thus, we can also identify it as finished stage later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
