Ngone51 commented on a change in pull request #27752: [SPARK-30999][SQL] Don't
cancel a QueryStageExec which failed before call doMaterialize
URL: https://github.com/apache/spark/pull/27752#discussion_r386247756
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala
##########
@@ -158,25 +158,34 @@ case class AdaptiveSparkPlanExec(
var result = createQueryStages(currentPhysicalPlan)
val events = new LinkedBlockingQueue[StageMaterializationEvent]()
val errors = new mutable.ArrayBuffer[SparkException]()
+ val runningStages = util.Collections.synchronizedSet(new
util.HashSet[QueryStageExec]())
Review comment:
Wait, wait. After taking another look, I realized that `cancel` has already
skipped finished stage. So, the problem, actually, only exists in stage which
fails to initialize lazy val. Thus, skip the *only one* failed stage should be
enough.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
