HeartSaVioR commented on a change in pull request #27747: [SPARK-30993][SQL]
Use its sql type for UDT when checking the type of length (fixed/var) or mutable
URL: https://github.com/apache/spark/pull/27747#discussion_r386413634
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/UserDefinedTypeSuite.scala
##########
@@ -287,4 +306,22 @@ class UserDefinedTypeSuite extends QueryTest with
SharedSparkSession with Parque
checkAnswer(spark.createDataFrame(data, schema).selectExpr("typeof(a)"),
Seq(Row("array<double>")))
}
+
+ test("SPARK-30993: UserDefinedType matched to fixed length SQL type
shouldn't be corrupted") {
+ def concatFoo(a: FooWithDate, b: FooWithDate): FooWithDate = {
+ FooWithDate(b.date, a.s + b.s, a.i)
+ }
+
+ UDTRegistration.register(classOf[LocalDateTime].getName,
classOf[LocalDateTimeUDT].getName)
+
+ // remove sub-millisecond part as we only use millis based timestamp while
serde
+ val date =
LocalDateTime.ofEpochSecond(LocalDateTime.now().toEpochSecond(ZoneOffset.UTC),
+ 0, ZoneOffset.UTC)
+ val inputDS = List(FooWithDate(date, "Foo", 1), FooWithDate(date, "Foo",
3),
+ FooWithDate(date, "Foo", 3)).toDS()
+ val agg = inputDS.groupByKey(x => x.i).mapGroups((_, iter) =>
iter.reduce(concatFoo))
+ val result = agg.collect()
+
+ assert(result.toSet === Set(FooWithDate(date, "FooFoo", 3),
FooWithDate(date, "Foo", 1)))
Review comment:
The output without the patch is follow:
```
Expected :Set(FooWithDate(2020-03-02T06:05:40,FooFoo,3),
FooWithDate(2020-03-02T06:05:40,Foo,1))
Actual :Set(FooWithDate(3108-12-26T09:51:48,FooFoo,3),
FooWithDate(3108-12-26T09:51:48,Foo,1))
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
