MaxGekk commented on a change in pull request #27756: 
[SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at split in 
Scala API
URL: https://github.com/apache/spark/pull/27756#discussion_r386539301
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala
 ##########
 @@ -2463,22 +2463,22 @@ object functions {
    * Splits str around matches of the given regex.
 
 Review comment:
   nit: This general comment refers to parameters, it seems. And `pattern` was 
replaced by `regex` here in in the original PR. How about _Splits str around 
matches of the given **pattern**_

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to