gengliangwang commented on a change in pull request #27370: [SPARK-30654]
Bootstrap4 WebUI upgrade
URL: https://github.com/apache/spark/pull/27370#discussion_r386651720
##########
File path: core/src/main/resources/org/apache/spark/ui/static/executorspage.js
##########
@@ -562,10 +562,10 @@ $(document).ready(function () {
$("#showAdditionalMetrics").append(
"<div><a id='additionalMetrics'>" +
- "<span class='expand-input-rate-arrow arrow-closed'
id='arrowtoggle-optional-metrics'></span>" +
+ "<span class='expand-input-rate-arrow arrow-closed'
id='arrowtoggle-optional-metrics'></span> " +
"Show Additional Metrics" +
"</a></div>" +
- "<div class='container-fluid container-fluid-div'
id='toggle-metrics' hidden>" +
+ "<div class='container-fluid-div ml-4 d-none'
id='toggle-metrics'>" +
Review comment:
I see. How about putting the margin-left into the CSS of
`container-fluid-div` so that we don't need to write 'ml-4' every time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
