yma11 commented on a change in pull request #27546: [SPARK-30773][ML]Support
NativeBlas for level-1 routines
URL: https://github.com/apache/spark/pull/27546#discussion_r386764088
##########
File path: mllib-local/pom.xml
##########
@@ -61,13 +61,17 @@
This spark-tags test-dep is needed even though it isn't used in this
module, otherwise testing-cmds that exclude
them will yield errors.
-->
+ <dependency>
Review comment:
If we leave the property in core, we need to import
org.apache.spark.internal.config to reference it in mllib-local thus still
can't avoid dependency of core module. Another option is that we implement a
logic to directly read this value from spark-defaults.conf through method like
System.getProperties, which will need no modification and dependency of core
module.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
