HyukjinKwon commented on a change in pull request #27648: [SPARK-24994][SQL] :
Support filter pushdown for short and byte without explicit casting
URL: https://github.com/apache/spark/pull/27648#discussion_r386773397
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -1802,3 +1803,85 @@ object OptimizeLimitZero extends Rule[LogicalPlan] {
empty(ll)
}
}
+
+/**
+ * Removes Cast expressions from predicates to push down the filters. This
will allow filter push
+ * down for byte and short columns without explicitly casting literals.
Review comment:
The approach basically looks same. Also, we should better generalise it so
other data sources can support. The current approach seems difficult to extend.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
