cloud-fan commented on a change in pull request #27718:
[SPARK-30885][SQL][FOLLOW-UP] Fix issues where some V1 commands allow tables
that are not fully qualified.
URL: https://github.com/apache/spark/pull/27718#discussion_r386966214
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/PlanResolutionSuite.scala
##########
@@ -771,17 +773,19 @@ class PlanResolutionSuite extends AnalysisTest {
}
test("support for other types in TBLPROPERTIES") {
- Seq("v1Table" -> true, "v2Table" -> false, "testcat.tab" -> false).foreach
{
- case (tblName, useV1Command) =>
+ Seq(TableIdentifier("v1Table", Some("default")) -> true,
+ TableIdentifier("v2Table") -> false,
+ TableIdentifier("testcat.tab") -> false).foreach {
+ case (tblIdent, useV1Command) =>
val sql =
s"""
- |ALTER TABLE $tblName
+ |ALTER TABLE ${tblIdent.table}
|SET TBLPROPERTIES ('a' = 1, 'b' = 0.1, 'c' = TRUE)
""".stripMargin
val parsed = parseAndResolve(sql)
if (useV1Command) {
val expected = AlterTableSetPropertiesCommand(
- TableIdentifier(tblName),
+ tblIdent,
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
