Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4818#discussion_r25540573
  
    --- Diff: 
yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala ---
    @@ -290,8 +290,18 @@ private[yarn] class YarnAllocator(
           location: String,
           containersToUse: ArrayBuffer[Container],
           remaining: ArrayBuffer[Container]): Unit = {
    +    // SPARK-6050: certain Yarn configurations return a resource 
configuration that doesn't match
    +    // the request; for example, capacity scheduler + 
DefaultResourceCalculator. Allow users in
    +    // those situations to disable resource matching.
    +    val matchingResource =
    +        if (sparkConf.getBoolean("spark.yarn.container.matchAnyResource", 
false)) {
    --- End diff --
    
    Huh, no, if you want to match any you want to use the `resource` field, not 
the value returned by yarn (`allocatedContainer.getResource`). That means the 
comparison will effectively be `resource == resource` which will always be true.
    
    I can change the config name if you think that would be clearer.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to