Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/4808#discussion_r25541695
--- Diff: python/pyspark/sql/types.py ---
@@ -64,6 +64,8 @@ def json(self):
sort_keys=True)
+# This singleton pattern does not work with pickle, you will get
--- End diff --
We discussed this, the old implementation is a bit of over optimization, I
think.
For PrimitiveTypeSingleton, the __dict__ is empty, so the new
implementation is not so heavy, so there will be no much performance difference.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
