dbtsai commented on a change in pull request #27728:
[SPARK-17636][SQL][test-hive1.2] Nested Column Predicate Pushdown for Parquet
URL: https://github.com/apache/spark/pull/27728#discussion_r387248516
##########
File path:
sql/core/v2.3/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFilters.scala
##########
@@ -64,9 +64,11 @@ private[sql] object OrcFilters extends OrcFiltersBase {
* Create ORC filter as a SearchArgument instance.
*/
def createFilter(schema: StructType, filters: Seq[Filter]):
Option[SearchArgument] = {
- val dataTypeMap = schema.map(f => f.name -> f.dataType).toMap
+ val dataTypeMap = schema.map(f => quoteAttributeNameIfNeeded(f.name) ->
f.dataType).toMap
// Combines all convertible filters using `And` to produce a single
conjunction
- val conjunctionOptional = buildTree(convertibleFilters(schema,
dataTypeMap, filters))
+ // TODO: ORC doesn't support predicate pushdown for nested field yet, so
they are removed.
Review comment:
Done. thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
