dongjoon-hyun commented on a change in pull request #27778: [SPARK-31027] [SQL]
Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#discussion_r387278397
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala
##########
@@ -22,68 +22,82 @@ import org.apache.spark.sql.catalyst.expressions._
import org.apache.spark.sql.catalyst.plans.PlanTest
import org.apache.spark.sql.sources
import org.apache.spark.sql.test.SharedSparkSession
+import org.apache.spark.sql.types.{IntegerType, StringType, StructField,
StructType}
class DataSourceStrategySuite extends PlanTest with SharedSparkSession {
+ val attrInts = Seq(
+ 'cint.int,
+ ).zip(Seq(
+ "cint",
+ ))
- test("translate simple expression") {
- val attrInt = 'cint.int
- val attrStr = 'cstr.string
+ val attrStrs = Seq(
+ 'cstr.int,
+ ).zip(Seq(
+ "cstr",
+ ))
+
+ test("translate simple expression") { attrInts.zip(attrStrs)
Review comment:
Indentation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
