Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4688#discussion_r25545466
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
 ---
    @@ -71,6 +72,16 @@ class CoarseGrainedSchedulerBackend(scheduler: 
TaskSchedulerImpl, val actorSyste
       // Executors we have requested the cluster manager to kill that have not 
died yet
       private val executorsPendingToRemove = new HashSet[String]
     
    +  /**
    +   * Send new credentials to executors. This is the method that is called 
when the scheduled
    +   * login completes, so the new credentials can be sent to the executors.
    +   * @param credentials
    +   */
    +  def sendNewCredentialsToExecutors(credentials: SerializableBuffer): Unit 
= {
    +    // We don't care about the reply, so going to deadLetters is fine.
    --- End diff --
    
    BTW, on top of that, the executor should not service any tasks before it 
downloads the credentials, so it either should request them before registering, 
or some other form of blocking should be added.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to