gengliangwang commented on a change in pull request #27765: [SPARK-31014][CORE]
InMemoryStore: remove key from parentToChildrenMap when removing key from
CountingRemoveIfForEach
URL: https://github.com/apache/spark/pull/27765#discussion_r387474359
##########
File path:
common/kvstore/src/main/java/org/apache/spark/util/kvstore/InMemoryStore.java
##########
@@ -177,7 +177,7 @@ public void clear() {
* iterators. https://bugs.openjdk.java.net/browse/JDK-8078645
*/
private static class CountingRemoveIfForEach<T> implements
BiConsumer<Comparable<Object>, T> {
- private final ConcurrentMap<Comparable<Object>, T> data;
+ private final InstanceList<T> data;
Review comment:
Nit: how about rename this to `list` or `instanceList`? It would be more
readable. There is another `private final ConcurrentMap<Class<?>,
InstanceList<?>> data = new ConcurrentHashMap<>();` in `InMemoryLists`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
