Ngone51 commented on a change in pull request #27786: [SPARK-31034][CORE]
ShuffleBlockFetcherIterator should always create request for last block group
URL: https://github.com/apache/spark/pull/27786#discussion_r387528372
##########
File path:
core/src/test/scala/org/apache/spark/storage/ShuffleBlockFetcherIteratorSuite.scala
##########
@@ -375,25 +427,27 @@ class ShuffleBlockFetcherIteratorSuite extends
SparkFunSuite with PrivateMethodT
blockManager,
blocksByAddress,
(_, in) => in,
- 35,
+ Int.MaxValue,
Int.MaxValue,
2,
Int.MaxValue,
true,
false,
metrics,
true)
-
var numResults = 0
+ // After initialize(), there will be 2 FetchRequests that one has 2 merged
blocks and another
Review comment:
note: `2 merged blocks` -> `2 ShuffleBlockBatch`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
