beliefer commented on a change in pull request #27744: [SPARK-30992][DSTREAMS]
Arrange scattered config of streaming module
URL: https://github.com/apache/spark/pull/27744#discussion_r387732530
##########
File path:
streaming/src/main/scala/org/apache/spark/streaming/util/StateMap.scala
##########
@@ -61,8 +62,7 @@ private[streaming] object StateMap {
def empty[K, S]: StateMap[K, S] = new EmptyStateMap[K, S]
def create[K: ClassTag, S: ClassTag](conf: SparkConf): StateMap[K, S] = {
- val deltaChainThreshold =
conf.getInt("spark.streaming.sessionByKey.deltaChainThreshold",
- DELTA_CHAIN_LENGTH_THRESHOLD)
+ val deltaChainThreshold = conf.get(SESSION_BY_KEY_DELTA_CHAIN_THRESHOLD)
Review comment:
I'm not sure about this, I hope someone will be more clear about this.
Maybe we need move `DELTA_CHAIN_LENGTH_THRESHOLD` form `StateMap.scala` to
`StreamingConf.scala`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
