ScrapCodes commented on issue #27800: [SPARK-31041][BUILD] Make arguments to make-distribution.sh position-independent URL: https://github.com/apache/spark/pull/27800#issuecomment-595051659 @nchammas, the patch looks good to me. We can make one more improvement though. The command `dev/make-distribution.sh`'s usage help, makes it very clear that maven cli option should be at the end. Since the error output if the user makes a mistake with the position of the `MAVEN_CLI_OPTIONS` is very misleading. So this patch is helpful ! The improvement, I would recommend is, is the user gives a misspelled CLI option, the error output is still misleading, it might as well be good to fix the error output. e.g. `./dev/make-distribution.sh --pip -r --tgz` Produces the error: `+ VERSION=' -X,--debug Produce execution debug output'` Which is not at all helpful.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
