Ngone51 commented on a change in pull request #27789: [SPARK-31050][TEST]
Disable flaky `Roundtrip` test in KafkaDelegationTokenSuite
URL: https://github.com/apache/spark/pull/27789#discussion_r388159919
##########
File path:
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaDelegationTokenSuite.scala
##########
@@ -62,7 +62,7 @@ class KafkaDelegationTokenSuite extends StreamTest with
SharedSparkSession with
}
}
- test("Roundtrip") {
+ ignore("Roundtrip") {
Review comment:
Hi @gaborgsomogyi , after taking a look of `BeforeAndAfterAll`, I think it
should be OK due to:
```
/**
* Flag to indicate whether to invoke beforeAll and afterAll even when
there are no tests expected.
*
* <p>
* The default value is <code>false</code>, which means beforeAll and
afterAll will not be invoked
* if there are no tests expected. Whether tests are expected is
determined by invoking <code>expectedTestCount</code> passing in
* the passed filter. Because this count does not include tests excluded
based on tags, such as ignored tests, this prevents
* any side effects in <code>beforeAll</code> or <code>afterAll</code> if
no tests will ultimately be executed anyway.
* If you always want to see the side effects even if no tests are
expected, override this <code>val</code> and set it to true.
* </p>
*/
val invokeBeforeAllAndAfterAllEvenIfNoTestsAreExpected = false
```
And I tested locally to verify it. So, we're temporary safe by now. But
please be aware of it as it can be easily break when people add any new test.
And, of course, your later fix should also get rid of it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
